On 12/11/2019 5:35 PM, Guenter Roeck wrote: > On 12/11/19 1:02 PM, Florian Fainelli wrote: >> Including au1000.h from the machine specific header directory prevents >> this driver from being built on any other platforms (MIPS included). >> Since we do not use any definitions, drop it. >> >> Reported-by: Denis Efremov <efremov@xxxxxxxxx> >> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> >> --- >> drivers/watchdog/mtx-1_wdt.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c >> index 25a92857b217..aeca22f7450e 100644 >> --- a/drivers/watchdog/mtx-1_wdt.c >> +++ b/drivers/watchdog/mtx-1_wdt.c >> @@ -41,8 +41,6 @@ >> #include <linux/uaccess.h> >> #include <linux/gpio/consumer.h> >> -#include <asm/mach-au1x00/au1000.h> >> - >> #define MTX1_WDT_INTERVAL (5 * HZ) >> static int ticks = 100 * HZ; >> > > Given that this is nothing but yet another gpio watchdog driver, I'd > personally rather have it merged with gpio_wdt.c. On a higher level, > cleaning up old-style watchdog drivers, without converting them to > using the watchdog core, is a waste of time. If that makes you feel any better, I was not planning on going further than that, and yes, removing this driver and using gpio_wdt.c would be the way to go, this driver greatly predates gpio_wdt.c and I have since then not had access to my MTX-1 platforms which is why this did not happen. We can attempt a "blind conversion" without testing, but what good would that make, not sure. > > Wim, should we make it a policy to reject patches into old-style drivers > unless they fix a real bug ? It is getting a pain to have to review those > patches. > > Thanks, > Guenter -- Florian
