Hi, Paul, Nearly all archs (including alpha) have supported syscall audit, can this mips audit patch be merged? Huacai On Sun, Sep 1, 2019 at 5:20 PM Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> wrote: > > > On 2019/2/6 下午8:01, Huacai Chen wrote: > > From: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > > > > The original patch is from Ralf. I have maintained it for more than six > > years on Loongson platform, and it works perfectly. Most of the commit > > messages are written by Ralf. > > > > MIPS doesn't quite fit into the existing pattern of other architectures > > and I'd appreciate your comments and maybe even an Acked-by. > > > > - Linux on MIPS extends the traditional syscall table used by older UNIX > > implementations. This is why 32-bit Linux syscalls are starting from > > 4000; the native 64-bit syscalls start from 5000 and the N32 compat ABI > > from 6000. The existing syscall bitmap is only large enough for at most > > 2048 syscalls, so I had to increase AUDIT_BITMASK_SIZE to 256 which > > provides enough space for 8192 syscalls. Because include/uapi/linux/ > > audit.h and AUDIT_BITMASK_SIZE are exported to userspace I've used an > > #ifdef __mips__ for this. > > > > - The code treats the little endian MIPS architecture as separate from > > big endian. Combined with the 3 ABIs that's 6 combinations. I tried > > to sort of follow the example set by ARM which explicitly lists the > > (rare) big endian architecture variant - but it doesn't seem to very > > useful so I wonder if this could be squashed to just the three ABIs > > without consideration of endianess? > > > > Signed-off-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > > Signed-off-by: Huacai Chen <chenhc@xxxxxxxxxx> > > Reviewed-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > > Any update about this patch? > > Thanks. > > -- > > Jiaxun Yang >
