Re: [PATCH] MIPS: Remove GCC_IMM_ASM & GCC_REG_ACCUM macros

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 7 Nov 2018, Paul Burton wrote:

> diff --git a/arch/mips/kernel/cpu-bugs64.c b/arch/mips/kernel/cpu-bugs64.c
> index c9e8622b5a16..bada74af7641 100644
> --- a/arch/mips/kernel/cpu-bugs64.c
> +++ b/arch/mips/kernel/cpu-bugs64.c
> @@ -92,7 +92,7 @@ static inline void mult_sh_align_mod(long *v1, long *v2, long *w,
>  		".set	pop"
>  		: "=&r" (lv1), "=r" (lw)
>  		: "r" (m1), "r" (m2), "r" (s), "I" (0)
> -		: "hi", "lo", GCC_REG_ACCUM);
> +		: "hi", "lo", "$0");

 You can remove GCC_REG_ACCUM altogether rather than replacing it with 
"$0" as $0 cannot be clobbered. ;)

 I chose this construct for sane syntax, so that we don't have to invent 
things to have "accum" optionally there (e.g. having GCC_REG_ACCUM defined 
to `, "accum"' would be crazy, IMHO).

  Maciej


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux