Re: [PATCH] MIPS: Avoid using .set mips0 to restore ISA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

Paul Burton wrote:
> We currently have 2 commonly used methods for switching ISA within
> assembly code, then restoring the original ISA.
> 
> 1) Using a pair of .set push & .set pop directives. For example:
> 
> .set	push
> .set	mips32r2
> <some_insn>
> .set	pop
> 
> 2) Using .set mips0 to restore the ISA originally specified on the
> command line. For example:
> 
> .set	mips32r2
> <some_insn>
> .set	mips0
> 
> Unfortunately method 2 does not work with nanoMIPS toolchains, where the
> assembler rejects the .set mips0 directive like so:
> 
> Error: cannot change ISA from nanoMIPS to mips0
> 
> In preparation for supporting nanoMIPS builds, switch all instances of
> method 2 in generic non-platform-specific code to use push & pop as in
> method 1 instead. The .set push & .set pop is arguably cleaner anyway,
> and if nothing else it's good to consistently use one method.
> 
> Signed-off-by: Paul Burton <paul.burton@xxxxxxxx>

Applied to mips-next.

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@xxxxxxxx to report it. ]


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux