Re: [PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails

Paul Burton <paul.burton@xxxxxxxx> · Wed, 17 Oct 2018 20:19:12 +0000

Hi Huacai,

On Wed, Oct 17, 2018 at 08:29:53AM +0800, Huacai Chen wrote:
> Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF
> property_read_u32 instead of get_property,read_number") makes cache
> size and number_of_sets be 0 if DT doesn't provide there values. I
> think this is unreasonable so make them keep the old values, which is
> the same as old kernels.
> 
> Signed-off-by: Huacai Chen <chenhc@xxxxxxxxxx>
> ---
>  drivers/base/cacheinfo.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Since this isn't a MIPS-related patch you'll need to send it to the
maintainers & reviewers for the file you modified. They would be:

  $ ./scripts/get_maintainer.pl -f drivers/base/cacheinfo.c 
  Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
    (supporter:DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS)
  "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
    (reviewer:DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS)
  linux-kernel@xxxxxxxxxxxxxxx (open list)

Thanks,
    Paul