Re: [PATCH] ip22-gio.c: fix missing return value check of kzalloc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jiecheng,

On Fri, Aug 17, 2018 at 09:46:16AM +0800, Jiecheng Wu wrote:
> Function ip22_check_gio() defined in arch/mips/sgi-ip22/ip22-gio.c
> calls kzalloc() to allocate memory for struct gio_device which is
> dereferenced immediately. As kzalloc() may return NULL when OOM
> happens, this code piece may cause NULL pointer dereference bug.
> ---
>  arch/mips/sgi-ip22/ip22-gio.c | 2 ++
>  1 file changed, 2 insertions(+)

Please wrap your commit messages at 75 characters as described in
Documentation/process/submitting-patches.rst, and as I've done above.

You also need to add a Signed-off-by line at the end of your commit
message, which indicates that you agree that the developer's certificate
of origin applies to your patch - again described in the document above.

Thanks for your patches, but I won't apply them without this.

Paul


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux