Re: [PATCH v2 net-next 5/7] net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Hauke Mehrtens <hauke@xxxxxxxxxx>
Subject: Re: [PATCH v2 net-next 5/7] net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver
From: Andrew Lunn <andrew@xxxxxxx>
Date: Sat, 1 Sep 2018 20:12:53 +0200
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, vivien.didelot@xxxxxxxxxxxxxxxxxxxx, f.fainelli@xxxxxxxxx, john@xxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxx, dev@xxxxxxxxx, hauke.mehrtens@xxxxxxxxx, devicetree@xxxxxxxxxxxxxxx
In-reply-to: <20180901120427.9983-1-hauke@hauke-m.de>
References: <20180901114535.9070-1-hauke@hauke-m.de> <20180901120427.9983-1-hauke@hauke-m.de>
User-agent: Mutt/1.5.23 (2014-03-12)

> +struct xrx200_priv {
> +	struct net_device_stats stats;

net_device has a stats structure in it. Please use that one.

Otherwise, this looks good.

	Andrew

References:
- [PATCH v2 net-next 0/7] Add support for Lantiq / Intel vrx200 network
  - From: Hauke Mehrtens
- [PATCH v2 net-next 5/7] net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver
  - From: Hauke Mehrtens

Prev by Date: Re: [PATCH v2 net-next 3/7] net: dsa: Add Lantiq / Intel GSWIP tag support
Next by Date: Re: [PATCH v2 net-next 7/7] net: dsa: Add Lantiq / Intel DSA driver for vrx200
Previous by thread: [PATCH v2 net-next 5/7] net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver
Next by thread: Re: [PATCH v2 net-next 5/7] net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver
Index(es):
- Date
- Thread

[Index of Archives] [Linux MIPS Home] [LKML Archive] [Linux ARM Kernel] [Linux ARM] [Linux] [Git] [Yosemite News] [Linux SCSI] [Linux Hams]

Powered by Linux