Hi Christoph, On Mon, Aug 27, 2018 at 04:50:27PM +0200, Christoph Hellwig wrote: > Subject: [RFC] merge dma_direct_ops and dma_noncoherent_ops > > While most architectures are either always or never dma coherent for a > given build, the arm, arm64, mips and soon arc architectures can have > different dma coherent settings on a per-device basis. Additionally > some mips builds can decide at boot time if dma is coherent or not. > > I've started to look into handling noncoherent dma in swiotlb, and > moving the dma-iommu ops into common code [1], and for that we need a > generic way to check if a given device is coherent or not. Moving > this flag into struct device also simplifies the conditionally coherent > architecture implementations. > > These patches are also available in a git tree given that they have > a few previous posted dependencies: > > git://git.infradead.org/users/hch/misc.git dma-direct-noncoherent-merge > > Gitweb: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-direct-noncoherent-merge Apart from the nits in patch 2, these look sane to me from a MIPS perspective, so for patches 1-4: Acked-by: Paul Burton <paul.burton@xxxxxxxx> # MIPS parts Thanks, Paul
