On 17/07/2018 15:11:50+0300, Andy Shevchenko wrote: > On Tue, 2018-07-17 at 13:48 +0200, Alexandre Belloni wrote: > > Factorize setting the SDA hold time in a new function > > i2c_dw_set_sda_hold_time() that is used for both master and slave > > mode. > > > > This conveniently pulls the fix for the spurious warning from commit > > 7a20e707aae2 ("i2c: designware: suppress unneeded SDA hold time > > warnings") > > in slave mode. > > Isn't this a duplication of > > commit 1080ee7e28e1cea86310739e5dd4612868768aed > Author: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> > Date: Tue Jun 19 14:23:22 2018 +0300 > > i2c: designware: Move SDA hold time configuration to common code > > ? > Indeed, I was on 4.18-rc1, not -next. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com