Hi Ralf, On Mon, Jul 02, 2018 at 05:20:29PM +0200, Ralf Baechle wrote: > On Fri, Jun 22, 2018 at 11:07:03AM -0700, Paul Burton wrote: > > > In show_regs() we have a regs argument of type struct pt_regs *, and we > > explicitly cast it to that same type as part of calling __show_regs(). > > > > Casting regs to the same type that it is declared as does nothing at > > all, so remove the useless cast. > > Good catch but there's no dump_stack() in v4.18-rc3 so this doesn't apply. dump_stack() is there in mips-fixes as part of fixing up arch_trigger_cpumask_backtrace(), so this would apply once the next fixes pull happens. But I'm all for cleaning up other instances too. Thanks, Paul