Re: [PATCH v4] MIPS: Octeon: Remove unused CIU types and macros.

[Paul Burton <paul.burton@xxxxxxxx>]

Hi Steven,

On Mon, Jul 02, 2018 at 09:28:37AM -0500, Steven J. Hill wrote:
> +	if ((cvmx_get_proc_id() & OCTEON_PRID_MASK) == OCTEON_CN68XX)
> +		return CVMX_CIU_ADDR(0x100100600, coreid, 0xffff, 8);
> +	else
> +		return CVMX_CIU_ADDR(0x0680, coreid, 0xffff, 8);

Nope - that still isn't going to work...

We have in asm/octeon/octeon-model.h:

  #define OM_IGNORE_REVISION      0x01000000
  #define OCTEON_CN68XX_PASS2_0   0x000d9108
  #define OCTEON_CN68XX           (OCTEON_CN68XX_PASS2_0 | OM_IGNORE_REVISION)

So that gives us the equivalent of:

  #define OCTEON_CN68XX           0x010d9108

You take the result of cvmx_get_proc_id() and AND it with:

  #define OCTEON_PRID_MASK        0x00ffffff

After this bits 31:24 will always be zero, and therefore the resulting
value can *never* equal OCTEON_CN68XX which has bit 24 set.

Thanks,
    Paul