Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h
From: Paul Burton <paul.burton@xxxxxxxx>
Date: Wed, 20 Jun 2018 17:02:23 -0700
Cc: Arnd Bergmann <arnd@xxxxxxxx>, Linux Kbuild mailing list <linux-kbuild@xxxxxxxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>, Linux-MIPS <linux-mips@xxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Matthew Wilcox <matthew@xxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Douglas Anderson <dianders@xxxxxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Matthias Kaehlcke <mka@xxxxxxxxxxxx>, He Zhe <zhe.he@xxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Michal Marek <michal.lkml@xxxxxxxxxxx>, Khem Raj <raj.khem@xxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Stafford Horne <shorne@xxxxxxxxx>, Gideon Israel Dsouza <gidisrael@xxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, linuxppc-dev <linuxppc-dev@xxxxxxxxxxxxxxxx>
In-reply-to: <CAK7LNAQRu0p8_8DqEdmUUPfc4gC60SSj90vTpz3iKaiE596-TA@mail.gmail.com>
References: <20180616005323.7938-1-paul.burton@mips.com> <20180616005323.7938-2-paul.burton@mips.com> <CAK7LNASvCha27kU4ipn23uOpNuxkzJrNzWBwYcxN4n=3xtv8SA@mail.gmail.com> <20180619190225.7eguhiw3ixaiwpgl@pburton-laptop> <CAK7LNAQRu0p8_8DqEdmUUPfc4gC60SSj90vTpz3iKaiE596-TA@mail.gmail.com>
User-agent: NeoMutt/20180512

Hi Masahiro,

On Thu, Jun 21, 2018 at 08:21:01AM +0900, Masahiro Yamada wrote:
> V2 is good except one nit.
> (I left a comment in it)

Thanks, and yes I agree with your comment that the GCC<4.6 __diag()
definition can be removed.

> I can fix it up locally if it is tedious to re-spin, though.

If you wouldn't mind that'd be great :)

Thanks,
    Paul

References:
- [PATCH 0/3] Resolve -Wattribute-alias warnings from SYSCALL_DEFINEx()
  - From: Paul Burton
- [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h
  - From: Paul Burton
- Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h
  - From: Masahiro Yamada
- Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h
  - From: Paul Burton
- Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h
  - From: Masahiro Yamada

Prev by Date: Re: [PATCH 4/7] MIPS: boot: correct prerequisite image of vmlinux.*.its
Next by Date: Re: Build regressions/improvements in v4.18-rc1
Previous by thread: Re: [PATCH 1/3] kbuild: add macro for controlling warnings to linux/compiler.h
Next by thread: Re: [PATCH 0/3] Resolve -Wattribute-alias warnings from SYSCALL_DEFINEx()
Index(es):
- Date
- Thread

[Index of Archives] [Linux MIPS Home] [LKML Archive] [Linux ARM Kernel] [Linux ARM] [Linux] [Git] [Yosemite News] [Linux SCSI] [Linux Hams]