Booleans should be assigned true/false not 1/0 as comparison is not needed Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx> --- Problem located by scripts/coccinelle/misc/boolinit.cocci ./arch/mips/cavium-octeon/octeon-irq.c:817:3-13: WARNING: Assignment of bool to 0/1 Patch was compile tested with: cavium_octeon_defconfig (with a number of sparse warnings - not related to the proposed change) Patch is against 4.17.0 (localversion-next is next-20180614) arch/mips/cavium-octeon/octeon-irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c index b3aec10..31be6a9 100644 --- a/arch/mips/cavium-octeon/octeon-irq.c +++ b/arch/mips/cavium-octeon/octeon-irq.c @@ -814,7 +814,7 @@ static int octeon_irq_ciu_set_affinity(struct irq_data *data, pen = &per_cpu(octeon_irq_ciu1_en_mirror, cpu); if (cpumask_test_cpu(cpu, dest) && enable_one) { - enable_one = 0; + enable_one = false; __set_bit(cd->bit, pen); } else { __clear_bit(cd->bit, pen); -- 2.1.4