Hi Steven,
On Tue, Jun 05, 2018 at 12:24:52AM -0500, Steven J. Hill wrote:
> Clean up usage of 'cvmx-sysinfo.h' header file. Also sort the
> inclusing of header files and update copyrights.
Inclusion? Including?
What was wrong with the existing usage of cvmx-sysinfo.h?
Why are these 3 changes being made as one patch?
This commit message doesn't really say anything useful, and other
patches in the series have the same problem.
> diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> index ab8362e..971c03e 100644
> --- a/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> +++ b/arch/mips/cavium-octeon/executive/cvmx-helper-board.c
> @@ -4,7 +4,7 @@
> * Contact: support@xxxxxxxxxxxxxxxxxx
> * This file is part of the OCTEON SDK
> *
> - * Copyright (c) 2003-2008 Cavium Networks
> + * Copyright (C) 2003-2018 Cavium, Inc.
All these copyright changes:
1) Make it more difficult to read the patch & see what the actual code
changes are, and;
2) Seem pretty unnecessary especially for something as trivial as
moving around a bunch of header inclusions.
> diff --git a/arch/mips/include/asm/octeon/cvmx-sysinfo.h b/arch/mips/include/asm/octeon/cvmx-sysinfo.h
> index c6c3ee3..f1a11a9 100644
> --- a/arch/mips/include/asm/octeon/cvmx-sysinfo.h
> +++ b/arch/mips/include/asm/octeon/cvmx-sysinfo.h
> @@ -4,7 +4,7 @@
> * Contact: support@xxxxxxxxxxxxxxxxxx
> * This file is part of the OCTEON SDK
> *
> - * Copyright (c) 2003-2016 Cavium, Inc.
> + * Copyright (C) 2003-2018 Cavium, Inc.
> *
> * This file is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License, Version 2, as
> @@ -32,7 +32,7 @@
> #ifndef __CVMX_SYSINFO_H__
> #define __CVMX_SYSINFO_H__
>
> -#include "cvmx-coremask.h"
> +#include<asm/octeon/cvmx-bootinfo.h>
Space between #include & the '<' please.
Also why is this change being made at all? Both before and after this
series cvmx-sysinfo.h doesn't use anything from cvmx-bootinfo.h, but it
does use struct cvmx_coremask from cvmx-coremask.h. Therefore including
cvmx-coremask.h seems like the right thing to do, although it would look
better to do so using <asm/octeon/cvmx-coremask.h>.
Thanks,
Paul
