On Wed, May 30, 2018 at 04:25:52PM -0700, Paul Burton wrote:
> > +static const struct octeon_dma_map_ops octeon_gen2_ops = {
> > + .phys_to_dma = octeon_hole_phys_to_dma,
> > + .dma_to_phys = octeon_hole_dma_to_phys,
> > +};
>
> These are pointers to functions of the wrong type, right? phys_to_dma &
> dma_to_phys have the struct device * argument but the octeon_hole_*
> functions do not. I'd expect we either need to restore the
> octeon_gen2_* wrappers that you remove below or change the definition of
> the octeon_hole_* functions.
That is true. I have no idea how that passed the buildbot, which
reported all kinds of other issues in the original octeon conversion.
I'll fix this for the next respin.
