On Tue, 03 Apr 2018 06:51:06 PDT (-0700), matt.redfearn@xxxxxxxx wrote:
Hi Palmer,
On 29/03/18 22:59, Palmer Dabbelt wrote:
On Thu, 29 Mar 2018 03:41:21 PDT (-0700), matt.redfearn@xxxxxxxx wrote:
From: Palmer Dabbelt <palmer@xxxxxxxxxx>
As part of the MIPS conversion to use the generic GCC library routines,
Matt Redfearn discovered that I'd missed a notrace on __ucmpdi2(). This
patch rectifies the problem.
CC: Matt Redfearn <matt.redfearn@xxxxxxxx>
CC: Antony Pavlov <antonynpavlov@xxxxxxxxx>
Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxx>
Reviewed-by: Matt Redfearn <matt.redfearn@xxxxxxxx>
Signed-off-by: Matt Redfearn <matt.redfearn@xxxxxxxx>
---
Changes in v4: None
Changes in v3: None
Changes in v2:
add notrace to lib/ucmpdi2.c
lib/ucmpdi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ucmpdi2.c b/lib/ucmpdi2.c
index 25ca2d4c1e19..597998169a96 100644
--- a/lib/ucmpdi2.c
+++ b/lib/ucmpdi2.c
@@ -17,7 +17,7 @@
#include <linux/module.h>
#include <linux/libgcc.h>
-word_type __ucmpdi2(unsigned long long a, unsigned long long b)
+word_type notrace __ucmpdi2(unsigned long long a, unsigned long long b)
{
const DWunion au = {.ll = a};
const DWunion bu = {.ll = b};
Ah, thanks, I think I must have forgotten about this. I assume these
three are going through your tree?
Yeah I think that's the plan - James will need your ack to patch 2 if
that's ok.
OK, I think I acked the right one... :)
