Re: [PATCH] MIPS: BCM47XX: Use __initdata for the bcm47xx_leds_pdata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Mar 23, 2018 at 11:58:07PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@xxxxxxxxxx>
> 
> This struct variable is used during init only. It gets passed to the
> gpio_led_register_device() which creates its own data copy. That allows
> using __initdata and saving some minimal amount of memory.
> 
> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>

Reviewed-by: Aaro Koskinen <aaro.koskinen@xxxxxx>

A.

> ---
>  arch/mips/bcm47xx/leds.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/bcm47xx/leds.c b/arch/mips/bcm47xx/leds.c
> index 8307a8a02667..fb87a6c54bc9 100644
> --- a/arch/mips/bcm47xx/leds.c
> +++ b/arch/mips/bcm47xx/leds.c
> @@ -521,7 +521,7 @@ bcm47xx_leds_simpletech_simpleshare[] __initconst = {
>   * Init
>   **************************************************/
>  
> -static struct gpio_led_platform_data bcm47xx_leds_pdata;
> +static struct gpio_led_platform_data bcm47xx_leds_pdata __initdata;
>  
>  #define bcm47xx_set_pdata(dev_leds) do {				\
>  	bcm47xx_leds_pdata.leds = dev_leds;				\
> -- 
> 2.11.0
> 
> 


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux