Hi Rob, On 6 March 2018 at 19:25, Rob Herring <robh+dt@xxxxxxxxxx> wrote: > On Tue, Mar 6, 2018 at 3:32 AM, James Hogan <jhogan@xxxxxxxxxx> wrote: >> On Mon, Sep 18, 2017 at 07:32:40PM +0530, PrasannaKumar Muralidharan wrote: >>> Add RNG node to jz4780 dtsi. This driver uses registers that are part of >>> the register set used by Ingenic CGU driver. Use regmap in RNG driver to >>> access its register. Create 'simple-bus' node, make CGU and RNG node as >>> child of it so that both the nodes are visible without changing CGU >>> driver code. > > The goal should be to avoid changing the DT (because the h/w hasn't > changed), not avoid changing a driver. Please have a look at the discussion happened at https://patchwork.linux-mips.org/patch/14094/. Looks like there is a difference in though process between you and mips folks. I am not an expert in DT so please suggest me the correct way to go about this. >>> >>> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@xxxxxxxxx> >> >> Better late than never: >> Acked-by: James Hogan <jhogan@xxxxxxxxxx> >> >> (I presume its okay for the reg ranges to overlap, ISTR that being an >> issue a few years ago, but maybe thats fixed now). > > No, that should be avoided. It does work because we have existing > cases that have to be supported. I am sorry but I require guidance here. Do you have any suggestion on how this should be. >> >> Cheers >> James Thanks and regards, PrasannaKumar
