On Sat, Feb 17, 2018 at 12:10:25PM -0800, Paul Burton wrote: > The MIPS Boston development board uses the Intel EG20T Platform > Controller Hub, including its gigabit ethernet controller, and requires > that its RTL8211E PHY be reset much like the Minnow platform. Pull the > PHY reset GPIO handling out of Minnow-specific code such that it can be > shared by later patches. Hi Paul I'm i right in saying the driver currently supports the Atheros AT8031 PHY? The same phy which is supported in drivers/net/phy/at803x.c? If so, i think you are doing this all wrong. You would be much better off throwing away pch_gbe_phy.c and write a proper MDIO driver. You then get the PHY driver for free, and the MDIO code could will handle your GPIO for you, in the standardised way. Andrew