On Thu, Feb 15, 2018 at 09:38:48PM +0000, James Hogan wrote: > On Thu, Feb 15, 2018 at 06:42:03PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Jan 31, 2018 at 10:24:45PM +0000, James Hogan wrote: > > > Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and > > > USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is > > > conditional upon USB && USB_SUPPORT, so that it can be freely selected > > > by platform Kconfig symbols in architecture code. > > > > > > For example once the MIPS_GENERIC platform selects are fixed in the > > > patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN", the MIPS > > > 32r6_defconfig warns like so: > > > > > > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB) > > > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB) > > > > > > Signed-off-by: James Hogan <jhogan@xxxxxxxxxx> > > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > Cc: Corentin Labbe <clabbe.montjoie@xxxxxxxxx> > > > Cc: linux-usb@xxxxxxxxxxxxxxx > > > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Thanks, I'll apply this as a MIPS fix for 4.16. > > Okay to leave patch 2 for you to deal with Greg since it doesn't really > directly affect MIPS nor is it important for 4.16? Just take both of them and be done with it :) thanks, greg k-h