On Wed, Jan 17, 2018 at 07:55:27PM +0000, James Hogan wrote:
> On Wed, Jan 17, 2018 at 07:56:38PM +0100, Corentin Labbe wrote:
> > MIPS_GENERIC select some options with condition on BIG_ENDIAN which do
> > not exists.
> > Replace BIG_ENDIAN by CPU_BIG_ENDIAN which is the correct kconfig name.
> > Note that BMIP_GENERIC do the same which confirm that this patch is
> > needed.
> >
> > Fixes: eed0eabd12ef0 ("MIPS: generic: Introduce generic DT-based board support")
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>
>
> Good spot:
> Reviewed-by: James Hogan <jhogan@xxxxxxxxxx>
>
> Probably worthy of a backport too:
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.9+
For the record, this needs the patch "usb: Move USB_UHCI_BIG_ENDIAN_*
out of USB_SUPPORT" [1] to avoid Kconfig warnings.
Thanks
James
[1] https://patchwork.linux-mips.org/patch/18559/
>
> Cheers
> James
>
> > ---
> > arch/mips/Kconfig | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index 13c6e5cb6055..504e78ff0b00 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -119,12 +119,12 @@ config MIPS_GENERIC
> > select SYS_SUPPORTS_MULTITHREADING
> > select SYS_SUPPORTS_RELOCATABLE
> > select SYS_SUPPORTS_SMARTMIPS
> > - select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> > - select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> > - select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> > - select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> > - select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> > - select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> > + select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> > + select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> > + select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> > + select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> > + select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> > + select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> > select USE_OF
> > help
> > Select this to build a kernel which aims to support multiple boards,
> > --
> > 2.13.6
> >
> >
Attachment:
signature.asc
Description: Digital signature
