On Wed, Jan 24, 2018 at 03:11:44PM +0100, Christoph Hellwig wrote:
> On Wed, Jan 24, 2018 at 02:02:35PM +0000, James Hogan wrote:
> > On Thu, Nov 16, 2017 at 04:35:55PM +0800, Huacai Chen wrote:
> > > To support coherent & non-coherent DMA co-exsistance, we should add
> > > cache_sync to loongson_dma_map_ops.
> > >
> > > Signed-off-by: Huacai Chen <chenhc@xxxxxxxxxx>
> >
> > I presume this was broken by commit c9eb6172c328 ("dma-mapping: turn
> > dma_cache_sync into a dma_map_ops method") in 4.15-rc1? (Christoph Cc'd)
>
> I don't think that is the case.
>
> In mips only mips_default_dma_map_ops supports DMA_ATTR_NON_CONSISTENT,
> and mips_default_dma_map_ops grew support for the dma_cache_sync
> operation.
>
> Neither Octeon nor longsoon respect the DMA_ATTR_NON_CONSISTENT argument
> to dma_alloc_attrs, so there is no point in implementing dma_cache_sync
> for them.
I see, that makes sense. Thanks Christoph. I'll assume this patch isn't
applicable then unless Huacai adds some explanation.
Cheers
James
Attachment:
signature.asc
Description: Digital signature
