Hi James, On Tue, Oct 31, 2017 at 09:41:07PM +0000, James Hogan wrote: > From: James Hogan <jhogan@xxxxxxxxxx> > > Since commit 04a85e087ad6 ("MIPS: generic: Move NI 169445 FIT image > source to its own file"), a generic 32r2el_defconfig kernel fails to > build with the following build error: > > ITB arch/mips/boot/vmlinux.gz.itb > Error: arch/mips/boot/vmlinux.gz.its:111.1-2 syntax error > FATAL ERROR: Unable to parse input tree > mkimage Can't read arch/mips/boot/vmlinux.gz.itb.tmp: Invalid argument Hmm - I fixed this up already here: https://patchwork.linux-mips.org/patch/16941/ and Ralf said he was going to fix up the original commit. I guess it got lost somewhere..? Thanks, Paul > This is because arch/mips/generic/board-ni169445.its.S doesn't include > the necessary "/" node path before the first open brace, which did > previously exist when it was in arch/mips/generic/vmlinux.its.S. > > Fixes: 04a85e087ad6 ("MIPS: generic: Move NI 169445 FIT image source to its own file") > Signed-off-by: James Hogan <jhogan@xxxxxxxxxx> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > Cc: Paul Burton <paul.burton@xxxxxxxx> > Cc: Nathan Sullivan <nathan.sullivan@xxxxxx> > Cc: linux-mips@xxxxxxxxxxxxxx > --- > arch/mips/generic/board-ni169445.its.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/generic/board-ni169445.its.S b/arch/mips/generic/board-ni169445.its.S > index d12e12fe90be..e4cb4f95a8cc 100644 > --- a/arch/mips/generic/board-ni169445.its.S > +++ b/arch/mips/generic/board-ni169445.its.S > @@ -1,4 +1,4 @@ > -{ > +/ { > images { > fdt@ni169445 { > description = "NI 169445 device tree"; > -- > 2.14.1 >