Hi Paul, I think you're likely the person to review this patch? Jason On Mon, Oct 23, 2017 at 7:20 PM, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > When task_struct was moved, this MIPS code was neglected. Evidently > nobody is using it anymore. This fixes this build error: > > In file included from ./arch/mips/include/asm/thread_info.h:15:0, > from ./include/linux/thread_info.h:37, > from ./include/asm-generic/current.h:4, > from ./arch/mips/include/generated/asm/current.h:1, > from ./include/linux/sched.h:11, > from arch/mips/kernel/smp-cmp.c:22: > arch/mips/kernel/smp-cmp.c: In function ‘cmp_boot_secondary’: > ./arch/mips/include/asm/processor.h:384:41: error: implicit declaration > of function ‘task_stack_page’ [-Werror=implicit-function-declaration] > #define __KSTK_TOS(tsk) ((unsigned long)task_stack_page(tsk) + \ > ^ > arch/mips/kernel/smp-cmp.c:84:21: note: in expansion of macro ‘__KSTK_TOS’ > unsigned long sp = __KSTK_TOS(idle); > ^~~~~~~~~~ > > Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > --- > arch/mips/kernel/smp-cmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/kernel/smp-cmp.c b/arch/mips/kernel/smp-cmp.c > index 05295a4909f1..415e4d19f897 100644 > --- a/arch/mips/kernel/smp-cmp.c > +++ b/arch/mips/kernel/smp-cmp.c > @@ -19,7 +19,7 @@ > #undef DEBUG > > #include <linux/kernel.h> > -#include <linux/sched.h> > +#include <linux/sched/task_stack.h> > #include <linux/smp.h> > #include <linux/cpumask.h> > #include <linux/interrupt.h> > -- > 2.14.2 >
