On Tue, Oct 17, 2017 at 09:12:22AM -0700, Florian Fainelli wrote: > > Please move this into the arm arch code. > > No, this needs to work on both ARM and ARM64, hence the reason why this > is in a reasonably architecture neutral place. So there is no other shared code between the ARM and ARM64 ports for this SOC? > >> +EXPORT_SYMBOL(brcmstb_memory_phys_addr_to_memc); > > > >> +EXPORT_SYMBOL(brcmstb_memory_memc_size); > > > > Why is this exported? > > Because the PCIE RC driver can be built as a module. Hmm, supporting PCIE RC as module sounds odd, but it seems like there are a few others like that. At least make it EXPORT_SYMBOL_GPL() then to document the internal nature.
