Re: [PATCH 06/11] MIPS: cmpxchg: Implement __cmpxchg() as a function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

On 05/10/17 17:07, Paul Burton wrote:
>> On Fri, 9 Jun 2017 17:26:38 -0700, Paul Burton wrote:
>>> Replace the macro definition of __cmpxchg() with an inline function,
>>> which is easier to read & modify. The cmpxchg() & cmpxchg_local()
>>> macros are adjusted to call the new __cmpxchg() function.
>>>
>>> Signed-off-by: Paul Burton <paul.burton@xxxxxxxxxx>
>>> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
>>> Cc: linux-mips@xxxxxxxxxxxxxx
>>
>> I think this patch is breaking user space for me. I say "think"
>> because it is a bit tricky to bisect for the few patches previous to this one
>> since they won't compile cleanly for me (due to this
>> https://www.spinics.net/lists/mips/msg68727.html).
>>
>> I have a Cavium Octeon 5010 MIPS64 CPU on a custom board, have been
>> running it for years running various kernel versions. Linux-4.13 breaks for me,
>> and I bisected back to this change.
>>
>> What I see is user space bomb strait after boot with console messages like
>> this:
>>
>> mount[37] killed because of sig - 11
>>
>> STACK DUMP:
>> <snip>
>>
>> I get a lot of them from various programs running from rc scripts.
>> It never manages to fully boot to login/shell.
>>
>> If I take the linux-4.12 arch/mips/include/asm/cmpxchg.h and drop that in
>> place on a linux-4.13 (or even linux-4.14-rc3) I can compile and run everything
>> successfully.
>>
>> Any thoughts?
> 
> Are you running a uniprocessor/non-SMP kernel?

Yes, CONFIG_SMP not set.


> Could you try this fix I submitted this fix 5 weeks ago:
> 
> https://patchwork.linux-mips.org/patch/17226/

Yep, that fixes it. Thanks for the quick response.


> Ralf: Could we get that merged please?

Since this is a problem in linux-4.13 then a candidate for linux-4.13 stable too?

Regards
Greg


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux