Re: [PATCH] MIPS: ath79: support devicetree selection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 6 Sep 2017 14:32:00 +0200
Rocco Folino <rocco.folino@xxxxxxxxx> wrote:

> On Wed, Sep 06, 2017 at 02:20:05PM +0200, Alban wrote:
> > On Wed, 6 Sep 2017 13:14:35 +0200
> > Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote:
> >   
> > > On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> > >   
> > > > Allow to choose devicetrees from Kconfig.
> > > > 
> > > > Signed-off-by: Rocco Folino <rocco.folino@xxxxxxxxx>  
> > 
> > I don't really see the point of this patch. Building the dtb doesn't
> > take any significant time, so why add this extra complexity?  
> 
> Because you need to select the SoC type in order to enable some
> drivers, for example on the AR9331 to use the serial you need the
> CONFIG_SERIAL_AR933X which depends on the CONFIG_SOC_AR933X.

Seeing as this driver is the only one that make use of CONFIG_SOC_AR933X
I would prefer removing this dependency. It would also open the way to have
the driver built in COMPILE_TEST. A few more fixes might be needed but that
would be better than such a workaround.

Alban

Attachment: pgpBU7YGNG7gZ.pgp
Description: OpenPGP digital signature


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux