This patch fixes an incorrectly fixed up use of __ffs() on a 64 bit integer, and a missed usage of CM_GCR_GIC_STATUS_GICEX. Signed-off-by: Paul Burton <paul.burton@xxxxxxxxxx> Fixes: 4f1f490f010b ("MIPS: CM: Use BIT/GENMASK for register fields, order & drop shifts") Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> Cc: linux-mips@xxxxxxxxxxxxxx --- arch/mips/kernel/mips-cm.c | 2 +- arch/mips/mti-malta/malta-dtshim.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/kernel/mips-cm.c b/arch/mips/kernel/mips-cm.c index b0d670af5cb1..e91c8c4e2eb5 100644 --- a/arch/mips/kernel/mips-cm.c +++ b/arch/mips/kernel/mips-cm.c @@ -391,7 +391,7 @@ void mips_cm_error_report(void) ulong core_id_bits, vp_id_bits, cmd_bits, cmd_group_bits; ulong cm3_cca_bits, mcp_bits, cm3_tr_bits, sched_bit; - cause = cm_error >> __ffs(CM3_GCR_ERROR_CAUSE_ERRTYPE); + cause = cm_error >> __ffs64(CM3_GCR_ERROR_CAUSE_ERRTYPE); ocause = cm_other >> __ffs(CM_GCR_ERROR_MULT_ERR2ND); if (!cause) diff --git a/arch/mips/mti-malta/malta-dtshim.c b/arch/mips/mti-malta/malta-dtshim.c index 59a723d9a95a..361f7c146b75 100644 --- a/arch/mips/mti-malta/malta-dtshim.c +++ b/arch/mips/mti-malta/malta-dtshim.c @@ -236,7 +236,7 @@ static void __init remove_gic(void *fdt) /* if we have a CM which reports a GIC is present, leave the DT alone */ err = mips_cm_probe(); - if (!err && (read_gcr_gic_status() & CM_GCR_GIC_STATUS_GICEX)) + if (!err && (read_gcr_gic_status() & CM_GCR_GIC_STATUS_EX)) return; if (malta_scon() == MIPS_REVISION_SCON_ROCIT) { -- 2.14.1