On 08/28/2017 02:33 AM, Miodrag Dinic wrote: > Hi Ralf, > > Even though I agree with your approach in handling this issue is more appropriate, > but the reason we isolated this option just for MIPS_GENERIC was because we > are not quite sure which MIPS platforms were using this option (and effectively i8042 driver), except for Malta. > So, we decided to go with a safer solution and deselect it only for platforms which we are most sure aren't going to use it. > > If you prefer to have this option sprinkled across platforms which are using it, please indicate which those are. FWIW, I had started something similar, see comments from Maciej: https://patchwork.linux-mips.org/patch/16226/ > > Kind regards, > Miodrag > > ________________________________________ > From: Ralf Baechle [ralf@xxxxxxxxxxxxxx] > Sent: Saturday, August 26, 2017 12:52 PM > To: Aleksandar Markovic > Cc: linux-mips@xxxxxxxxxxxxxx; Miodrag Dinic; Goran Ferenc; Aleksandar Markovic; Bo Hu; Douglas Leung; James Hogan; Jin Qian; Paul Burton; Petar Jovanovic; Raghu Gandham > Subject: Re: [PATCH v4 8/8] MIPS: Unselect ARCH_MIGHT_HAVE_PC_SERIO if MIPS_GENERIC > > On Fri, Aug 18, 2017 at 03:09:00PM +0200, Aleksandar Markovic wrote: > >> From: Miodrag Dinic <miodrag.dinic@xxxxxxxxxx> >> >> This effectively disables i8042 driver for MIPS_GENERIC kernel platform. >> Currently, only sead-3, boston and ranchu boards are supported by the >> MIPS generic kernel and none of them require this driver. >> More specifically, kernel would crash if it gets enabled, because >> i8042 driver would try to read from an non-existent IO register. > > And many more platforms would beneftig from disabling this option because > let's face it, the i8042's heydays are over. So rather than spreading > random depenencies on MIPS_GENERIC or other platforms through Kconfig > please push the select of ARCH_MIGHT_HAVE_PC_SERIO to the platforms. > > Ralf > -- Florian
