Re: [PATCH v2] MIPS: math-emu: do not use bools for arithmetic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 14, 2017 at 1:25 PM, Maciej W. Rozycki <macro@xxxxxxxxxx> wrote:
> On Mon, 14 Aug 2017, Manuel Lauss wrote:
>
>> ---
>> v2: just use xor, as suggested by Maciej.  No size changes this time, but still
>> untested due to lack of hardfloat userland.
>
>  D'oh, I was wondering what you meant by writing: "binary size reduction"
> and didn't get that you meant a size reduction of the binary object file
> produced rather than a transformation made by the compiler to the binary
> expression used.  That looks odd indeed -- have you tried comparing the
> output from `objdump -d' with and without the original patch applied?
>
>  Your change looks obviously correct to me, however I can push it through
> GCC and/or glibc IEEE 754 math regression testing if it'll make you feel
> more confident about it.

No need.  I've updated to gcc-7.2 and the differences are gone, the binary
cp1emu.o created with and without this patch are completely identical.

Thanks!
     Manuel




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux