Re: [PATCH v2 1/8] MIPS: Introduce CPU_ISA_GE_* Kconfig entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Steven,

On Monday, 14 August 2017 11:56:46 PDT Steven J. Hill wrote:
> On 08/14/2017 01:18 PM, Paul Burton wrote:
> 
> [...]
> 
> > With the new Kconfig entries introduced by this patch this can be
> > 
> > simplified to:
> >   default y if CPU_ISA_GE_R1
> 
> The idea for the patch is solid.

Thanks.

> Can we not just use CPU_ISA_R1,
> and so on? GE immediately makes me think "Graphics Engine" and
> there are the GE7 ASICs from old SGI hardware. Maybe it's just
> me and it doesn't confuse anyone else.

I went with "GE" because that matches what the MIPS instruction set uses in 
branch-compare instructions. I think leaving it out would make it unclear what 
the difference from the existing CPU_MIPSR1 etc entries is, but if something 
else would be clearer to people I'm open to suggestions.

Thanks,
    Paul

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux