Hello, Alexandre, In addition, if you, and everybody else, don't object, I plan to change the title of this patch form: "MIPS: ranchu: Add Goldfish RTC driver" to "rtc: Add Goldfish RTC driver", to be more consistent with all commit messages for this kernel source directory. Regards, Aleksandar ________________________________________ From: Miodrag Dinic Sent: Friday, August 11, 2017 9:46 AM To: Alexandre Belloni; Aleksandar Markovic Cc: linux-mips@xxxxxxxxxxxxxx; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@xxxxxxxxxxxxxxx; linux-rtc@xxxxxxxxxxxxxxx; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham Subject: RE: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver Hi Alexandre, we have this sorted & plan to submit version 4 of this series next week. Thank you. Kind regards, Miodrag ________________________________________ From: Alexandre Belloni [alexandre.belloni@xxxxxxxxxxxxxxxxxx] Sent: Thursday, August 10, 2017 10:34 PM To: Aleksandar Markovic Cc: linux-mips@xxxxxxxxxxxxxx; Miodrag Dinic; Goran Ferenc; Aleksandar Markovic; Alessandro Zummo; Bo Hu; David S. Miller; Douglas Leung; Greg Kroah-Hartman; James Hogan; Jin Qian; linux-kernel@xxxxxxxxxxxxxxx; linux-rtc@xxxxxxxxxxxxxxx; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham Subject: Re: [PATCH v3 2/8] MIPS: ranchu: Add Goldfish RTC driver Hi, On 21/07/2017 at 18:53:31 +0200, Aleksandar Markovic wrote: > From: Miodrag Dinic <miodrag.dinic@xxxxxxxxxx> > > Add device driver for a virtual Goldfish RTC clock. > > The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are > set. The compatible string used by OS for binding the driver is > defined as "google,goldfish-rtc". > > Signed-off-by: Miodrag Dinic <miodrag.dinic@xxxxxxxxxx> > Signed-off-by: Goran Ferenc <goran.ferenc@xxxxxxxxxx> > Signed-off-by: Aleksandar Markovic <aleksandar.markovic@xxxxxxxxxx> > --- > MAINTAINERS | 1 + > drivers/rtc/Kconfig | 8 ++ > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-goldfish.c | 233 +++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 243 insertions(+) > create mode 100644 drivers/rtc/rtc-goldfish.c > Do you mind fixing the remaining checkpatch --strict issues, the two kbuild errors and the warning reported by Julia? Thanks! -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
