Re: [PATCH 3/7] MIPS: NI 169445: Only include in 32r2el kernels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 07, 2017 at 04:01:14PM -0700, Paul Burton wrote:
> The NI 169445 board uses a little endian MIPS32r2 CPU, and therefore
> including board support in kernels that are unable to run on such a CPU
> is pointless.
> 
> Specify requirements in the board config fragment that cause the NI
> 169445 board support to only be included in generic kernels that target
> little endian MIPS32r2 CPUs.
> 
> For example, NI 169445 support will be included when configuring using
> 32r2el_defconfig but not when using 64r6_defconfig.
> 
> Signed-off-by: Paul Burton <paul.burton@xxxxxxxxxx>
> Cc: Nathan Sullivan <nathan.sullivan@xxxxxx>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxx
> 
> ---
> I'm basing this upon the Kconfig entries that were present in the
> initial upstream submission of NI 169445 board support[1]. If this is
> wrong at all please let me know :)
> 
> [1] https://www.linux-mips.org/archives/linux-mips/2016-12/msg00016.html
> 
>  arch/mips/configs/generic/board-ni169445.config | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/mips/configs/generic/board-ni169445.config b/arch/mips/configs/generic/board-ni169445.config
> index 0bae1f861a5b..f72223b366ca 100644
> --- a/arch/mips/configs/generic/board-ni169445.config
> +++ b/arch/mips/configs/generic/board-ni169445.config
> @@ -1,3 +1,6 @@
> +# require CONFIG_CPU_MIPS32_R2=y

Technically, won't this unnecessarily prevent it being included in r1
configs?

I suppose the only better suggestion I have at the moment is
# require CONFIG_32BIT=y
# require CONFIG_CPU_MIPS32_R6=n

I suppose being specific about exclusions is probably inevitable (e.g.
for boards which can't support micromips).

Cheers
James

> +# require CONFIG_CPU_LITTLE_ENDIAN=y
> +
>  CONFIG_FIT_IMAGE_FDT_NI169445=y
>  
>  CONFIG_SERIAL_8250=y
> -- 
> 2.14.0
> 
> 

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux