On Mon, Jul 24, 2017 at 08:47:55AM +0100, Matt Redfearn wrote: > Hi Steven, > > > On 21/07/17 20:05, Steven J. Hill wrote: > > On 07/21/2017 11:10 AM, Matt Redfearn wrote: > >> This is indeed still broken in v4.13-rc1 with some configurations: > >> > >> CC arch/mips/cavium-octeon/octeon-usb.o arch/mips/cavium-octeon/octeon-usb.c: In function ‘dwc3_octeon_device_init’: arch/mips/cavium-octeon/octeon-usb.c:540:4: error: implicit declaration of function ‘devm_iounmap’ [-Werror=implicit-function-declaration] devm_iounmap(&pdev->dev, base); ^ cc1: some warnings being treated as errors scripts/Makefile.build:302: recipe for target 'arch/mips/cavium-octeon/octeon-usb.o' failed > >> > > With "some" configurations? If I take a clean v4.13-rc1 tag and > > use the default 'arch/mips/configs/cavium_octeon_defconfig' file > > and revert the thin-AR patch, the kernel builds and links without > > any errors. If I go a step further and enable USB DesignWare 3 > > support the kernel still builds without errors. I have attached > > this config file for reference. I cannot reproduce your errors > > with a stock v4.13-rc1 kernel. > > I have bisected it for you. The Kconfig that causes the issue is SMP. > Steps to reproduce: > $ make cavium_octeon_defconfig > $ make menuconfig - Turn off CONFIG_SMP. > $ make clean arch/mips/cavium-octeon/octeon-usb.o > <snip> > CC [M] arch/mips/cavium-octeon/octeon-usb.o > arch/mips/cavium-octeon/octeon-usb.c: In function ‘dwc3_octeon_device_init’: > arch/mips/cavium-octeon/octeon-usb.c:540:4: error: implicit declaration > of function ‘devm_iounmap’ [-Werror=implicit-function-declaration] > devm_iounmap(&pdev->dev, base); > ^ > cc1: some warnings being treated as errors > scripts/Makefile.build:308: recipe for target > 'arch/mips/cavium-octeon/octeon-usb.o' failed > make[1]: *** [arch/mips/cavium-octeon/octeon-usb.o] Error 1 > Makefile:1662: recipe for target 'arch/mips/cavium-octeon/octeon-usb.o' > failed > make: *** [arch/mips/cavium-octeon/octeon-usb.o] Error 2 > > Applying this patch fixes the build. > > Tested-by: Matt Redfearn <matt.redfearn@xxxxxxxxxx> Thanks Matt, As for the original patch, with an improved commit message: Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx> Cheers James
Attachment:
signature.asc
Description: Digital signature
