> > ________________________________________ > From: James Hogan > Sent: Friday, July 21, 2017 8:42 AM > To: Aleksandar Markovic > Cc: linux-mips@xxxxxxxxxxxxxx; Aleksandar Markovic; Miodrag Dinic; Goran Ferenc; Douglas Leung; linux-kernel@xxxxxxxxxxxxxxx; Paul Burton; Petar Jovanovic; Raghu Gandham; Ralf Baechle > Subject: Re: [PATCH v3 08/16] MIPS: math-emu: <MAXA|MINA>.<D|S>: Fix cases of input values with opposite signs > > On Fri, Jul 21, 2017 at 04:09:06PM +0200, Aleksandar Markovic wrote: > > From: Aleksandar Markovic <aleksandar.markovic@xxxxxxxxxx> > > > > Fix the value returned by <MAXA|MINA>.<D|S>, if inputs are normal fp > > numbers of the same absolute value, but opposite signs. > > > > The relevant example: > > > > MAXA.S fd,fs,ft: > > If fs contains -3, and ft contains +3, fd is going to contain +3 > > (without this patch, it used to contain -3). > > I think its worth mentioning also that for MINA.*, it returns the > negative one when the absolute values are equal (The phrase "For equal > absolute values, returns the smallest positive argument" in the manual > is a bit ambiguous IMO, so I ended up checking what I6500 did). I am going to slightly rephrase the commit messege to address this. Regards, Aleksandar
