On 07/21/2017 09:10 AM, Matt Redfearn wrote:
Hi Steven
On 19/07/17 16:31, Steven J. Hill wrote:
On 07/19/2017 04:41 AM, James Hogan wrote:
Is this already fixed in some other way or is it some unusual
configuration? I couldn't reproduce any failure on 4.12 and you
haven't quoted the build error or explained what was missing that
required io.h to be included.
It appears things are working fine in 4.12, so I have dropped
this patch.
This is indeed still broken in v4.13-rc1 with some configurations:
CC arch/mips/cavium-octeon/octeon-usb.o
arch/mips/cavium-octeon/octeon-usb.c: In function
‘dwc3_octeon_device_init’:
arch/mips/cavium-octeon/octeon-usb.c:540:4: error: implicit declaration
of function ‘devm_iounmap’ [-Werror=implicit-function-declaration]
devm_iounmap(&pdev->dev, base);
^
cc1: some warnings being treated as errors
scripts/Makefile.build:302: recipe for target
'arch/mips/cavium-octeon/octeon-usb.o' failed
Steven: Please figure out what config causes this to break and see if
the patch fixes it.
One other question I have is: Is devm_release_mem_region() really the
inverse of platform_get_resource()?
David.
Thanks,
Matt
