On 17 July 2017 10:58:09 BST, Matt Redfearn <matt.redfearn@xxxxxxxxxx> wrote: >In v4.13, CLKSRC_PISTACHIO can select TIMER_OF on architectures without >GENERIC_CLOCKEVENTS, resulting in a struct clock_event_device missing >some required features. >Fix this by depending on GENERIC_CLOCKEVENTS. Additionally, since >Pistachio is a MIPS based SoC, also depend on the MIPS architecture. > >Thanks to kbuild test robot for finding this error >(https://lkml.org/lkml/2017/7/16/249) > >Signed-off-by: Matt Redfearn <matt.redfearn@xxxxxxxxxx> >--- > > drivers/clocksource/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >index fcae5ca6ac92..40ebb117709b 100644 >--- a/drivers/clocksource/Kconfig >+++ b/drivers/clocksource/Kconfig >@@ -262,7 +262,8 @@ config CLKSRC_LPC32XX > > config CLKSRC_PISTACHIO > bool "Clocksource for Pistachio SoC" if COMPILE_TEST >- depends on HAS_IOMEM >+ depends on GENERIC_CLOCKEVENTS && HAS_IOMEM >+ depends on MIPS Its already only configurable when COMPILE_TEST=y anyway, otherwise must be selected, so unless there's a hard build time dependency on mips i don't think this is necessary. it will prevent build testing in x86 allmodconfig. cheers James > select TIMER_OF > help > Enables the clocksource for the Pistachio SoC. -- James Hogan
