cc-ing Arve Hjønnevåg who originally upstreamed Goldfish FB driver cc-ing Jin Quian, Bo Hu & Lingfeng Yang from Google Hi Rob, Thanks for taking the time to review the patches > I don't know that this should even go upstream. There's no upstream > qemu support for goldfish-fb. Maybe this is a minor driver change, but > FB drivers are being replaced with DRM drivers. And the time for AOSP > supporting framebuffer drivers is limited I think with HWC2 and > explicit fence support in DRM. Goldfish FB is actively used by all supported architectures in Android (Intel/ARM/MIPS) and is part of Android emulator project and so far, there have been no limitations in AOSP for using it. We have already tested this particular version of the driver for MIPS Ranchu virtual platform (introduced in this series) which is DT based and therefore we needed to integrate device tree support for this driver. > bindings/display/ Did you mean to use this location instead of "bindings/goldfish/"? Kind regards, Miodrag ________________________________________ From: Rob Herring [robh+dt@xxxxxxxxxx] Sent: Friday, June 30, 2017 1:12 AM To: Aleksandar Markovic Cc: Linux-MIPS; Aleksandar Markovic; Miodrag Dinic; Goran Ferenc; devicetree@xxxxxxxxxxxxxxx; Douglas Leung; James Hogan; linux-kernel@xxxxxxxxxxxxxxx; Mark Rutland; Paul Burton; Petar Jovanovic; Raghu Gandham Subject: Re: [PATCH v2 06/10] Documentation: Add device tree binding for Goldfish FB driver On Wed, Jun 28, 2017 at 10:46 AM, Aleksandar Markovic <aleksandar.markovic@xxxxxxxxx> wrote: > From: Aleksandar Markovic <aleksandar.markovic@xxxxxxxxxx> > > Add documentation for DT binding of Goldfish FB driver. The compatible > string used by OS for binding the driver is "google,goldfish-fb". > > Signed-off-by: Miodrag Dinic <miodrag.dinic@xxxxxxxxxx> > Signed-off-by: Goran Ferenc <goran.ferenc@xxxxxxxxxx> > Signed-off-by: Aleksandar Markovic <aleksandar.markovic@xxxxxxxxxx> > --- > .../bindings/goldfish/google,goldfish-fb.txt | 18 ++++++++++++++++++ bindings/display/ I don't know that this should even go upstream. There's no upstream qemu support for goldfish-fb. Maybe this is a minor driver change, but FB drivers are being replaced with DRM drivers. And the time for AOSP supporting framebuffer drivers is limited I think with HWC2 and explicit fence support in DRM. Rob
