On Mon, 3 Jul 2017, James Hogan wrote: > > Hardcode the absence of the MIPS16e2 ASE for all the systems that do so > > for the MIPS16 ASE already, providing for code to be optimized away. > > > > Signed-off-by: Maciej W. Rozycki <macro@xxxxxxxxxx> > > I'm inclined to agree with Florian, that git formatted patches are > slightly easier to review, perhaps they just subjectively look more > familiar. Out of interest, do you not use git for retrieving kernel > source already? I do use GIT for managing the sources themselves of course, however I keep using `quilt' for patches for two main reasons: 1. It works efficiently for the work flow I've got used to, e.g. how do I hand-edit 16th previous diff with GIT; how do I swap patches; how do I move individual hunks between patches? -- these actions are trivial with `quilt'. 2. I don't use the same system for development as I do for submissions, also to make sure no unwanted bits leak by accident. Maybe `quilt' can be taught to prepend `diffstat' automagically itself; I'll check. > Thanks for the series. Thanks for your review! Maciej
