[RFC] MIPS: OCTEON: Spurious code in 'arch/mips/cavium-octeon/octeon-usb.c'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

The coccinelle script located at https://github.com/coccinelle/coccinellery/blob/master/notnull/notnull2.cocci
triggered a spurious code in 'arch/mips/cavium-octeon/octeon-usb.c'

It seems that 'dwc3_octeon_device_init()' can never return success (i.e. 0).
The 'do...while' loop exits only if 'node == NULL'. But, in such a case,
-ENODEV will be returned at the beginning of the loop.

I may miss something obvious, but I can't see how this code is supposed to
work.

Best regards.

CJ




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux