From: Miodrag Dinic <miodrag.dinic@xxxxxxxxxx> This driver is enabled by default for all MIPS platforms including the MIPS_GENERIC multiplaform kernel. If this driver probes the I8042_DATA_REG not knowing if the device exists it can cause a kernel to crash. Using check_legacy_ioport() interface we can selectively enable this driver only for the MIPS boards which actually have the i8042 controller. New "Ranchu" virtual platform does not support i8042 controller so it's added to the blacklist match table. Each MIPS machine should update this table with it's compatible strings if it does not support i8042 controller. Signed-off-by: Miodrag Dinic <miodrag.dinic@xxxxxxxxxx> Signed-off-by: Goran Ferenc <goran.ferenc@xxxxxxxxxx> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@xxxxxxxxxx> --- arch/mips/kernel/setup.c | 18 ++++++++++++++++++ drivers/input/serio/i8042-io.h | 2 +- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c index c22cde8..ccea90f 100644 --- a/arch/mips/kernel/setup.c +++ b/arch/mips/kernel/setup.c @@ -79,6 +79,15 @@ const unsigned long mips_io_port_base = -1; EXPORT_SYMBOL(mips_io_port_base); /* + * Here we blacklist all MIPS boards which do not have i8042 controller + */ +static const struct of_device_id i8042_blacklist_of_match[] = { + { .compatible = "mti,ranchu", }, + {}, +}; +#define I8042_DATA_REG 0x60 + +/* * Check for existence of legacy devices * * Some drivers may try to probe some I/O ports which can lead to @@ -90,9 +99,18 @@ EXPORT_SYMBOL(mips_io_port_base); */ int check_legacy_ioport(unsigned long base_port) { + const struct of_device_id *match; + struct device_node *np; int ret = 0; switch (base_port) { + case I8042_DATA_REG: + np = of_find_matching_node_and_match(NULL, + i8042_blacklist_of_match, &match); + if (np) + ret = -ENODEV; + of_node_put(np); + break; default: /* We will assume that the I/O device port exists if * not explicitly added to the blacklist match table diff --git a/drivers/input/serio/i8042-io.h b/drivers/input/serio/i8042-io.h index 34da81c..ec5fe9e 100644 --- a/drivers/input/serio/i8042-io.h +++ b/drivers/input/serio/i8042-io.h @@ -72,7 +72,7 @@ static inline int i8042_platform_init(void) * On some platforms touching the i8042 data register region can do really * bad things. Because of this the region is always reserved on such boxes. */ -#if defined(CONFIG_PPC) +#if defined(CONFIG_PPC) || defined(CONFIG_MIPS) if (check_legacy_ioport(I8042_DATA_REG)) return -ENODEV; #endif -- 2.7.4