On 06/15/2017 06:56 PM, Maciej W. Rozycki wrote: > On Mon, 5 Jun 2017, Florian Fainelli wrote: > >> Out of the many MIPS platforms only 3 appear to be actually using an >> I8042 keyboard controller: SGI, JAZZ and LOOGSON64, remove >> ARCH_MIGHT_HAVE_PC_SERIO from the top-level MIPS Kconfig symbol and move >> it down to those platforms that need it. > > How did you determine that? Malta for one not only has an SMSC FDC37M817 > Super I/O Controller featuring an 8042-compatible core, but actual PS/2 > keyboard and mouse connectors as well. I was just grepping for i8042 in platform code to determine that, this came after having SERIO accidentally enabled on my platform (BMIPS_GENERIC) and seeing that it crashed badly and it annoyed the crap out of me that MIPS had ARCH_MIGHT_HAVE_PC_SERIO for platforms that don't need it. Will come up with a v2 that includes malta, any other platforms for which it's not obvious? -- Florian