Hi,
On 09/03/17 14:14, Steven J. Hill wrote:
> From: "Steven J. Hill" <Steven.Hill@xxxxxxxxxx>
>
> Remove all unused bitfields and macros. Convert the remaining
> bitfields to use __BITFIELD_FIELD instead of #ifdef.
>
> Signed-off-by: Steven J. Hill <steven.hill@xxxxxxxxxx>
> Acked-by: David Daney <david.daney@xxxxxxxxxx>
This patch broke the EDAC_OCTEON_L2C driver which apparently uses some
of these "unused" structures. I therefore think this patch (or the
relevant parts of it which are still used) should be reverted for 4.12.
drivers/edac/octeon_edac-l2c.c: In function ‘octeon_l2c_poll_oct1’:
drivers/edac/octeon_edac-l2c.c:26:21: error: storage size of ‘l2d_err’ isn’t known
union cvmx_l2d_err l2d_err, l2d_err_reset;
^~~~~~~
drivers/edac/octeon_edac-l2c.c:26:30: error: storage size of ‘l2d_err_reset’ isn’t known
union cvmx_l2d_err l2d_err, l2d_err_reset;
^~~~~~~~~~~~~
drivers/edac/octeon_edac-l2c.c:44:30: error: ‘CVMX_L2D_ERR’ undeclared (first use in this function)
l2d_err.u64 = cvmx_read_csr(CVMX_L2D_ERR);
^~~~~~~~~~~~
drivers/edac/octeon_edac-l2c.c:44:30: note: each undeclared identifier is reported only once for each function it appears in
drivers/edac/octeon_edac-l2c.c:26:30: warning: unused variable ‘l2d_err_reset’ [-Wunused-variable]
union cvmx_l2d_err l2d_err, l2d_err_reset;
^~~~~~~~~~~~~
drivers/edac/octeon_edac-l2c.c:26:21: warning: unused variable ‘l2d_err’ [-Wunused-variable]
union cvmx_l2d_err l2d_err, l2d_err_reset;
^~~~~~~
drivers/edac/octeon_edac-l2c.c: In function ‘_octeon_l2c_poll_oct2’:
drivers/edac/octeon_edac-l2c.c:62:26: error: storage size of ‘err_tdtx’ isn’t known
union cvmx_l2c_err_tdtx err_tdtx, err_tdtx_reset;
^~~~~~~~
drivers/edac/octeon_edac-l2c.c:62:36: error: storage size of ‘err_tdtx_reset’ isn’t known
union cvmx_l2c_err_tdtx err_tdtx, err_tdtx_reset;
^~~~~~~~~~~~~~
drivers/edac/octeon_edac-l2c.c:63:26: error: storage size of ‘err_ttgx’ isn’t known
union cvmx_l2c_err_ttgx err_ttgx, err_ttgx_reset;
^~~~~~~~
drivers/edac/octeon_edac-l2c.c:63:36: error: storage size of ‘err_ttgx_reset’ isn’t known
union cvmx_l2c_err_ttgx err_ttgx, err_ttgx_reset;
^~~~~~~~~~~~~~
drivers/edac/octeon_edac-l2c.c:68:31: error: implicit declaration of function ‘CVMX_L2C_ERR_TDTX’ [-Werror=implicit-function-declaration]
err_tdtx.u64 = cvmx_read_csr(CVMX_L2C_ERR_TDTX(tad));
^~~~~~~~~~~~~~~~~
drivers/edac/octeon_edac-l2c.c:103:31: error: implicit declaration of function ‘CVMX_L2C_ERR_TTGX’ [-Werror=implicit-function-declaration]
err_ttgx.u64 = cvmx_read_csr(CVMX_L2C_ERR_TTGX(tad));
^~~~~~~~~~~~~~~~~
drivers/edac/octeon_edac-l2c.c:63:36: warning: unused variable ‘err_ttgx_reset’ [-Wunused-variable]
union cvmx_l2c_err_ttgx err_ttgx, err_ttgx_reset;
^~~~~~~~~~~~~~
drivers/edac/octeon_edac-l2c.c:63:26: warning: unused variable ‘err_ttgx’ [-Wunused-variable]
union cvmx_l2c_err_ttgx err_ttgx, err_ttgx_reset;
^~~~~~~~
drivers/edac/octeon_edac-l2c.c:62:36: warning: unused variable ‘err_tdtx_reset’ [-Wunused-variable]
union cvmx_l2c_err_tdtx err_tdtx, err_tdtx_reset;
^~~~~~~~~~~~~~
drivers/edac/octeon_edac-l2c.c:62:26: warning: unused variable ‘err_tdtx’ [-Wunused-variable]
union cvmx_l2c_err_tdtx err_tdtx, err_tdtx_reset;
^~~~~~~~
drivers/edac/octeon_edac-l2c.c: In function ‘octeon_l2c_probe’:
drivers/edac/octeon_edac-l2c.c:155:22: error: storage size of ‘l2d_err’ isn’t known
union cvmx_l2d_err l2d_err;
^~~~~~~
drivers/edac/octeon_edac-l2c.c:162:31: error: ‘CVMX_L2D_ERR’ undeclared (first use in this function)
l2d_err.u64 = cvmx_read_csr(CVMX_L2D_ERR);
^~~~~~~~~~~~
drivers/edac/octeon_edac-l2c.c:155:22: warning: unused variable ‘l2d_err’ [-Wunused-variable]
union cvmx_l2d_err l2d_err;
^~~~~~~
CC arch/mips/math-emu/sp_tint.o
cc1: some warnings being treated as errors
scripts/Makefile.build:308: recipe for target 'drivers/edac/octeon_edac-l2c.o' failed
make[4]: *** [drivers/edac/octeon_edac-l2c.o] Error 1
James
Attachment:
signature.asc
Description: OpenPGP digital signature
