Re: [PATCH V4 4/9] MIPS: Loongson-3: Support 4 packages in CPU Hwmon driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 13, 2017 at 5:45 PM, Ralf Baechle <ralf@xxxxxxxxxxxxxx> wrote:
> On Tue, Jun 06, 2017 at 11:14:43AM +0800, Huacai Chen wrote:
>
> (Fixing the Steven.Hill@xxxxxxxxxx address on cc, this email address is
> stale since a long time.  Steven is now Steven.Hill@xxxxxxxxxx.
>
>> Loongson-3 machines may have as many as 4 physical packages.
>
> Any reason why not dynamically allocating all structures, static allocations
> just won't scale to many packages nor are they very maintenance friendly.

Loongson-3 will no more than 4 packages, so we needn't allocating all
structures dynamically. However, I'll improve maintenability by
unifying get_cpu0_temp/get_cpu1_temp/get_cpu2_temp/get_cpu3_temp and
cpu0_temp_label/cpu_temp1_label/cpu2_temp_label/cpu3_temp_label.

Huacai

>
>   Ralf
>




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux