On Thu, 8 Jun 2017, Ralf Baechle wrote:
> > sigill_dsp:
> > - printk("%s: DSP branch but not DSP ASE - sending SIGBUS.\n", current->comm);
> > - force_sig(SIGBUS, current);
> > + pr_info("%s: DSP branch but not DSP ASE - sending SIGILL.\n",
> > + current->comm);
>
> Shouldn't this then maybe be a pr_debug then? With pr_info the right
> kind of program can produce lots of useless clutter.
Sure. Since I'm going to repost anyway to address Greg's concern, I'll
append an extra patch to the series, to change these all en masse, for
consistency.
Eventually I think they will all go as I suspect they cover an impossible
condition (so BUG_ON will be more appropriate), i.e. you can't get a
delay-slot exception for a branch that has not been implemented -- you'll
get a Reserved Instruction exception for the branch itself instead, and
then there's nothing to emulate. But I'll have to investigate execution
paths carefully first, verify that `delay_slot' is called consistently and
surely split off R2-on-R6 emulation code, before we can consider such a
change a safe operation.
Glad to see you back.
Maciej
