Re: [PATCH 4/4] MIPS: Branch straight to ll in mips_atomic_set()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 08, 2017 at 07:37:14AM +0100, Maciej W. Rozycki wrote:
> On Wed, 31 May 2017, David Daney wrote:
> 
> > > > The subsection keeps the code for the (hopefully) cold path out of line
> > > > which should result in a smaller cache footprint in the hot path.
> > > 
> > > Hmm, yes that would make sense if it did something useful there, but it
> > > just immediately jumps back to the ll.
> > 
> > In this case, it could be that the pattern was copied without carefully
> > examining what was being done.
> 
>  A PAUSE might be in order here.

Quite possibly, though I'm not sure its worth bothering to optimise this
old/unused code.

I had a patch somewhere to add PAUSE to spinlock loops...

Cheers
James

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux