On Mon, May 29, 2017 at 10:41:52AM +0200, Arnd Bergmann wrote: > On Sat, May 27, 2017 at 11:58 AM, Daniel Lezcano > <daniel.lezcano@xxxxxxxxxx> wrote: > > The CLOCKSOUCE_OF_DECLARE macro is used widely for the timers to declare the > > clocksource at early stage. However, this macro is also used to initialize > > the clockevent if any, or the clockevent only. > > > > It was originally suggested to declare another macro to initialize a > > clockevent, so in order to separate the two entities even they belong to the > > same IP. This was not accepted because of the impact on the DT where splitting > > a clocksource/clockevent definition does not make sense as it is a Linux > > concept not a hardware description. > > > > On the other side, the clocksource has not interrupt declared while the > > clockevent has, so it is easy from the driver to know if the description is > > for a clockevent or a clocksource, IOW it could be implemented at the driver > > level. > > > > So instead of dealing with a named clocksource macro, let's use a more generic > > one: TIMER_OF_DECLARE. > > > > The patch has not functional changes. > > > > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> > > Could you either leave the old name as an alias for one release, or introduce > the new name as an alias now for 4.13? > > I think that that would make it easier to merge new drivers. Otherwise this > looks good to me, New drivers should go through my tree, so I can catch them with the old macro name and do the change. > Acked-by: Arnd Bergmann <arnd@xxxxxxxx> Thanks for the review. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
