On 05/24/17 11:15, SF Markus Elfring wrote:
>>> +++ b/arch/mips/pci/pci-alchemy.c
>>> @@ -377,7 +377,6 @@ static int alchemy_pci_probe(struct platform_device *pdev)
>>>
>>> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>>> if (!ctx) {
>>> - dev_err(&pdev->dev, "no memory for pcictl context\n");
>>> ret = -ENOMEM;
>>> goto out;
>>> }
>>> --
>>> 2.13.0
>>
>> Why are you removing just this one dev_err()?
Agreed. Why just this one error message when there are many in this function?
> How do you think about to achieve a small code reduction also for this software module?
>
>
>> What issue are you trying to address?
>
> Do you find information from a Linux allocation failure report sufficient
> for such a function implementation?
Can you answer questions with statements instead of with questions?
thanks.
--
~Randy
