On 6 April 2017 at 16:55, James Hogan <james.hogan@xxxxxxxxxx> wrote:
> On Thu, Apr 06, 2017 at 04:23:24PM +0530, Amit Pundir wrote:
>> On 6 April 2017 at 14:59, James Hogan <james.hogan@xxxxxxxxxx> wrote:
>> > Is there a particular reason this is desired in stable? I was under the
>> > impression it was only helpful in the presence of a bug in the separate
>> > IRQ stack stuff in 4.11, which was fixed in the above mentioned commit
>> > de856416e714 ("MIPS: IRQ Stack: Fix erroneous jal to
>> > plat_irq_dispatch"), and otherwise just a nice to have cleanup.
>>
>> I picked up this patch from Lede source tree
>> https://github.com/lede-project/source/ for stable 4.9.
>>
>> >
>> > If you've cherry picked the IRQ stack work, have you also cherry-picked
>> > de856416e714?
>>
>> Thanks for pointing it out. I indeed missed out on picking
>> de856416e714 ("MIPS: IRQ Stack: Fix erroneous jal to
>> plat_irq_dispatch") and dda45f701c9d ("MIPS: Switch to the irq_stack
>> in interrupts"). Should I pick them too for 4.9/4.10 stable or drop
>> these 3 IRQ stack patches altogether if they are not stable material?
>
> I'd definitely drop this one.
Yes I'd drop this lone survivor too. I'll send the complete batch separately.
>
> Greg said he doesn't object to accepting the IRQ stack work once its
> been shaken out in mainline, at which point the fixes will be needed
> too:
>
> https://marc.info/?l=linux-mips&m=148449064421154&w=2
>
> Though note that its more than just the one patch:
>
> https://patchwork.linux-mips.org/project/linux-mips/list/?series=23&state=*
>
> (I seem to remember somebody saying LEDE had applied these patches).
I see all these patches in LEDE source too. Sorted out for both 4.4
and 4.9 already. I'll send them on stable shortly.
Regards,
Amit Pundir
>
> Cheers
> James
