Re: [PATCH v3] MIPS: PCI: add controllers before the specified head

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 26, 2017 at 07:05:36PM +0200, Mathias Kresin wrote:

> 
> With commit 23dac14d058f ("MIPS: PCI: Use struct list_head lists") new
> controllers are added after the specified head where they where added
> before the specified head previously.
> 
> Use list_add_tail to restore the former order.
> 
> This patches fixes the following PCI error on lantiq:
> 
>   pci 0000:01:00.0: BAR 0: error updating (0x1c000004 != 0x000000)
> 
> Fixes: 23dac14d058f ("MIPS: PCI: Use struct list_head lists")
> Signed-off-by: Mathias Kresin <dev@xxxxxxxxx>

Thanks Mathias, will apply.

Had I replied earlier, I would have requested the change you did yourself
in v3.  It seems to me the more logic solution and also closer to the
code before Paul's 23dac14d058f changed it.

I'm going to take care of Sergei's nit also, no need to resend.

  Ralf




[Index of Archives]     [Linux MIPS Home]     [LKML Archive]     [Linux ARM Kernel]     [Linux ARM]     [Linux]     [Git]     [Yosemite News]     [Linux SCSI]     [Linux Hams]

  Powered by Linux